updating fullstory module and adding rollup-based build #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-fs
changed the title
|
@patrick-fs Looks good to me. On a side note, what do you think about using Typescript (at least for the interfaces)? At Sentry we are currently migrating to TS and I think it's pretty standard for packages these days. |
|
@scefali I'm very pro-TypeScript! |
scefali
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Steve,
I have:
@fullstorydev/browserNPM packagerollupbuild configI haven't actually tested this yet, but wanted to get your eyes on it for review. I won't merge into
developwithout running a smoke test first.